Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: plugins: cloud_init: support interfaces with dash
Code Review
gerrit at ovirt.org
Wed Jun 7 10:20:31 UTC 2017
>From Sandro Bonazzola <sbonazzo at redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: plugins: cloud_init: support interfaces with dash
......................................................................
plugins: cloud_init: support interfaces with dash
Re-use ovirt-setup-lib instead of duplicating
code for getting local ip address for an interface.
As side effect, fix an issue we had not detecting interfaces
with dashes in the name.
Change-Id: I429786cf018ff4e891e7e36fa7e96ef9f5e30494
Related-To: https://bugzilla.redhat.com/1452243
Bug-Url: https://bugzilla.redhat.com/1459229
Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
---
M ovirt-hosted-engine-setup.spec.in
M src/plugins/gr-he-common/vm/cloud_init.py
2 files changed, 7 insertions(+), 32 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77904
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I429786cf018ff4e891e7e36fa7e96ef9f5e30494
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael at rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
More information about the Engine-commits
mailing list