Change in ovirt-engine[master]: core: Refactor of setting disk attributes.

[Code Review]

>From Maor Lipchuk <mlipchuk at redhat.com>:

Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Refactor of setting disk attributes.
......................................................................


core: Refactor of setting disk attributes.

Engine updates the new disk image with updated size and actual size
attributes based on the downloaded image retrieved from Glance.
The engine reads the image using inputstream and therefore
makes it hard to maintain for extra fields to update.

The proposed patch refactors the update of the disk image fields, to
be done inside the parsing method, making diskImage a parameter in
the method signature.

Change-Id: Iea7f2c6b566d9436d9799c56e86901e956ec49ae
Bug-Url: https://bugzilla.redhat.com/1456432
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java
1 file changed, 20 insertions(+), 16 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/77670
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea7f2c6b566d9436d9799c56e86901e956ec49ae
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>