Change in ovirt-engine[ovirt-engine-4.1]: core: change order of validations in RemoveStorageDomainCommand

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: change order of validations in RemoveStorageDomainCommand
......................................................................


core: change order of validations in RemoveStorageDomainCommand

Currently when attempting to remove a storage domain, part of the
validation process attempts to mount a storage domain to check if
it's attached to a DC and then disconnects. If the storage is already
attached, disconnecting from it may trigger a master domain
reconstruction (if it's the master) and it shouldn't do that.

The patch moves the isStorageDomainAttached check to the end of the
validation since we can fail earlier by querying the database and
discovering the domain is already attached without triggering the
reconstruction.

Change-Id: Id13fa174e79441b6c0641b7b7190efe16f99fbfc
Bug-Url: https://bugzilla.redhat.com/1444120
Signed-off-by: Benny Zlotnik <bzlotnik at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RemoveStorageDomainCommand.java
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Benny Zlotnik: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/77957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id13fa174e79441b6c0641b7b7190efe16f99fbfc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>