Change in ovirt-engine[master]: backend: introduce SyncAttachedDirectLunsCommand

[Code Review]

>From Daniel Erez <derez at redhat.com>:

Daniel Erez has submitted this change and it was merged.

Change subject: backend: introduce SyncAttachedDirectLunsCommand
......................................................................


backend: introduce SyncAttachedDirectLunsCommand

This patch introduces a new command to synchronize direct luns that are
attached to VMs in a given data center.
It is useful when upgrading a data center or when a direct lun
lacks some information because it was created via the REST API without a
host.
The command gets the data center id and synchronizes all the attached
direct luns in it. It can also get one or more attached direct luns ids
and synchronize only them.

Note that the reason that we can't synchronize a floating direct lun is
that it can be done by a host from any of the data centers, and hosts
from different data centers might return different information about the
lun. When a direct lun is attached to a VM, we pick a random host from
the data center that this vm belongs to and use it to synchtonize the
lun's information.

Change-Id: I62b2d6a19400c180ae5869990df92639bbaa9b3b
Related-To:https://bugzilla.redhat.com/1404389
Related-To:https://bugzilla.redhat.com/1455547
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommandTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncAttachedDirectLunsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDaoImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskLunMapDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskVmElementDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/LunDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/disk_lun_map_sp.sql
20 files changed, 342 insertions(+), 5 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/77101
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62b2d6a19400c180ae5869990df92639bbaa9b3b
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>