Change in ovirt-engine[ovirt-engine-4.1]: webadmin, userportal: Improve GWT symbol map handling

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin,userportal: Improve GWT symbol map handling
......................................................................


webadmin,userportal: Improve GWT symbol map handling

Before this patch, GWT .symbolMap files were installed through
optional `{webadmin-portal,userportal}-debuginfo` RPM packages,
which used the following layout:

  $PREFIX/share/ovirt-engine/gwt-symbols/webadmin/symbolMaps/
  $PREFIX/share/ovirt-engine/gwt-symbols/userportal/symbolMaps/

with above directories containing <gwtPermStrongName>.symbolMap
files. This had two main drawbacks:

  1, GWT symbol maps were optional (not available right after
     Engine installation), imposing one extra step when trying
     to diagnose and fix GWT UI related problems

  2, GWT symbol maps are big: 9 locales x 3 user agents = 27
     .symbolMap files for each GWT application, for WebAdmin
     each .symbolMap file is ~37 M (x 27 = ~1 G)

After this patch, GWT .symbolMap files are part of the core UI
packages, using the following layout:

  $PREFIX/share/ovirt-engine/gwt-symbols/webadmin/symbolMaps.zip
  $PREFIX/share/ovirt-engine/gwt-symbols/userportal/symbolMaps.zip

This solves both issues listed above. In case of an uncaught UI
exception, `OvirtRemoteLoggingService` servlet opens the .zip
file (using Java 8 zip FileSystem support) and streams relevant
.symbolMap content needed for Java stack trace de-obfuscation.

This also means that `{webadmin-portal,userportal}-debuginfo`
RPM packages are now unnecessary and are therefore removed.

Change-Id: I083a3b8ad5588f56b8569c862240591a44002326
Bug-Url: https://bugzilla.redhat.com/1431545
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M Makefile
M backend/manager/modules/restapi/apidoc/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
A frontend/webadmin/modules/frontend-assemblies/pom.xml
A frontend/webadmin/modules/frontend-assemblies/src/main/resources/assemblies/gwt-symbols.xml
D frontend/webadmin/modules/frontend-symbols/pom.xml
D frontend/webadmin/modules/frontend-symbols/resources/userportal/.keep
D frontend/webadmin/modules/frontend-symbols/resources/webadmin/.keep
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/OvirtRemoteLoggingService.java
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M ovirt-engine.spec.in
M pom.xml
15 files changed, 161 insertions(+), 148 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/77892
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I083a3b8ad5588f56b8569c862240591a44002326
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>