Change in ovirt-engine[ovirt-engine-4.1]: backend: introduce SyncStorageDomainsLunsCommand

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: backend: introduce SyncStorageDomainsLunsCommand
......................................................................


backend: introduce SyncStorageDomainsLunsCommand

This patch introduces a new command to synchronize all active block
storage domains in a given data center.

Previously, when synchronizing more than one storage domain (when
upgrading a data center or when activating a host where the other hosts
in the data center are not active), the engine used to call
SyncLunsInfoForBlockStorageDomainCommand for each storage domain.
The problem was that SyncLunsInfoForBlockStorageDomainCommand used to
call GetVgInfoVDSCommand, so for each storage domain we did a full
roundtrip to vdsm and back to the engine.

With this patch, SyncStorageDomainsLunsCommand calls GetDeviceList only
once, and uses that information to update all the domains in the data
center. Therefore, when synchronizing n domains, the engine should do
it ~ n times faster than it did before.

Change-Id: I744ae190397e00856ed67b99046efd1b1bb26054
Related-To:https://bugzilla.redhat.com/1404389
Related-To:https://bugzilla.redhat.com/1455547
Related-To:https://bugzilla.redhat.com/1455548
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AbstractSyncLunsCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncStorageDomainsLunsCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/AbstractSyncLunsCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncStorageDomainsLunsCommandTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncLunsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
6 files changed, 380 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/78058
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I744ae190397e00856ed67b99046efd1b1bb26054
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>