Change in ovirt-engine[master]: core: refactor OVF_STORE update on deactivate
Code Review
gerrit at ovirt.org
Mon Jun 12 12:21:51 UTC 2017
>From Maor Lipchuk <mlipchuk at redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: refactor OVF_STORE update on deactivate
......................................................................
core: refactor OVF_STORE update on deactivate
Move the logic which updates the OVF_STORE of a deactivated storage
domain to a new command.
The new command is UpdateOvfStoreForStorageDomainCommand which
responsible to update the OVF_STORE disk for a storage domain.
Change-Id: I1858b60b2247f347dc80c8120d5318f147da1192
Bug-Url: https://bugzilla.redhat.com/1403581
Bug-Url: https://bugzilla.redhat.com/1404607
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/UpdateOvfStoreForStorageDomainCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/UpdateOvfStoreForStorageDomainCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
4 files changed, 144 insertions(+), 13 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/76906
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1858b60b2247f347dc80c8120d5318f147da1192
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list