Change in ovirt-engine[master]: core:Remove redundant parameter class.
Code Review
gerrit at ovirt.org
Mon Jun 12 12:21:51 UTC 2017
>From Maor Lipchuk <mlipchuk at redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Remove redundant parameter class.
......................................................................
core:Remove redundant parameter class.
There is no use with updateStorage boolean flag in
ProcessOvfUpdateForStoragePoolParameters therefore there is no
reason to keep it as a parameter class so removing it
and instead use StoragePoolParametersBase.
Change-Id: Ifc2ec1c7a24c8d7aa61bda84b346c16bc83c1da7
Bug-Url: https://bugzilla.redhat.com/1403581
Bug-Url: https://bugzilla.redhat.com/1404607
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdater.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProcessOvfUpdateForStoragePoolParameters.java
5 files changed, 9 insertions(+), 35 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/78053
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc2ec1c7a24c8d7aa61bda84b346c16bc83c1da7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list