Change in ovirt-engine[master]: userportal, webadmin: work around GWT-P memory leak

[Code Review]

>From Vojtech Szocs <vszocs at redhat.com>:

Vojtech Szocs has submitted this change and it was merged.

Change subject: userportal, webadmin: work around GWT-P memory leak
......................................................................


userportal, webadmin: work around GWT-P memory leak

We encountered a fairly large memory leak in the latest
version of GWT-P. All GWT-P popups have a resize handler
attached to them, but this handler lives at window scope
and never lets go. Therefore, every popup is completely
leaked when closed.

However, luckily, the method in GWT-P that sets up this
handler has a hook/template method for disabling the addition
of the handler:
    if (repositionOnWindowResize()) {
         Window.addResizeHandler(new ResizeHandler() ...

We simply overload repositionOnWindowResize() to always
return false and the leak is worked around.

See: https://github.com/ArcBees/GWTP/issues/823

Change-Id: I4e6d4da68e3f50f5863f4e33e62581b97e36dd2d
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractPopupView.java
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Vojtech Szocs: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78025
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e6d4da68e3f50f5863f4e33e62581b97e36dd2d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>