Change in ovirt-engine[master]: webadmin: AppErrors.properties removed

Code Review gerrit at ovirt.org
Thu Jun 15 12:14:13 UTC 2017


>From Tomas Jelinek <tjelinek at redhat.com>:

Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: AppErrors.properties removed
......................................................................


webadmin: AppErrors.properties removed

When GWT translates AppError in 'webadmin' project, it checks
*.properties files of appropriate name on classpath. If 'webadmin'
project doesn't provide translations, *.properties file of 'frontend'
project  is used. This patch leverages this fact to reduce number
AppErrors.properties files.

Records of 'webadmin' were merged to 'fronted' project in a way that no
effective translations are changed (up to typo fixes). Differences were
manually resolved.

Userportal project can still have its own specific translations.

This means that from this patch on AppErrors translations has to be
edited only in projects 'fronted', 'userportal' and 'dal'.

Change-Id: Ic46c8b674662f9acb20e9be390ca4aab4b52b985
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
2 files changed, 116 insertions(+), 1,495 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests
  Phillip Bailey: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/76215
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic46c8b674662f9acb20e9be390ca4aab4b52b985
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list