Change in ovirt-engine[master]: webadmin: Add ErrorMessagesTest to frontend module
Code Review
gerrit at ovirt.org
Thu Jun 15 20:27:55 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Add ErrorMessagesTest to frontend module
......................................................................
webadmin: Add ErrorMessagesTest to frontend module
Commit 25603e [rightfully!] removed ErrorMessagesTest from the
webadmin module, as it no longer has an AppErrors.properties file,
after it was removed in 6d4008.
That patch, however, neglected to add an ErrorMessagesTest to the new
frontend location.
This patch adds back the missing test and removes the redundant key in
the properties file found by the said test.
Change-Id: I570eb1d7f48a4b53e5408e5d670f6d4dc6b607d9
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/ErrorMessagesTest.java
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78228
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I570eb1d7f48a4b53e5408e5d670f6d4dc6b607d9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list