Change in ovirt-engine[master]: webadmin: TakesConstrainedValueListEditor streams

Code Review gerrit at ovirt.org
Tue Jun 20 17:08:57 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: TakesConstrainedValueListEditor streams
......................................................................


webadmin: TakesConstrainedValueListEditor streams

Reimplement TakesConstrainedValueListEditor#createListOfLists with
Java 8 streams instead of boiler-plate for-looping over the input
list to make the code cleaner and easier to maintain.

Change-Id: Iea9bdbae9f2c0fa1de27aa64119147ef206a0205
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/TakesConstrainedValueListEditor.java
1 file changed, 2 insertions(+), 5 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea9bdbae9f2c0fa1de27aa64119147ef206a0205
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list