Change in ovirt-engine[master]: core: Skip content type checks when removing snapshot memory...

Code Review gerrit at ovirt.org
Thu Jun 22 15:07:58 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Skip content type checks when removing snapshot memory volume
......................................................................


core: Skip content type checks when removing snapshot memory volume

Commit 2087f033 introduced a protection on deletion of memory images,
however, since snapshot removal is removing those disks through
RemoveDiskCommand the operation will be blocked upon snapshot with memory
removal which should succeed.
This patch adds the option to suppress content type checks upon disk
removal and use it when removing a snapshot with memory

Bug-Url: https://bugzilla.redhat.com/1464100
Change-Id: I82278e9f302225b2f7146b7c81344294d8ed41ca
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDiskParameters.java
4 files changed, 14 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/78521
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82278e9f302225b2f7146b7c81344294d8ed41ca
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list