Change in ovirt-engine[ovirt-engine-4.1]: webadmin: make each disk appear on its own separate line

Code Review gerrit at ovirt.org
Sun Jun 25 08:39:26 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: make each disk appear on its own separate line
......................................................................


webadmin: make each disk appear on its own separate line

Currently when multiple disks are selected to be moved,
the disks allocation dialog makes some of the disk's fields appear
in the previous row instead.

Fixed by wrapping each disk with a bootstrap row.

Before screenshot: http://i.imgur.com/ucne2s4.png
After screenshot: http://i.imgur.com/q9ZIWKD.png

Change-Id: I86981b1538f08e728842dcc974ebfb45bd2aea83
Bug-Url: https://bugzilla.redhat.com/1436766
Signed-off-by: Benny Zlotnik <bzlotnik at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.ui.xml
2 files changed, 44 insertions(+), 26 deletions(-)

Approvals:
  Benny Zlotnik: Verified
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/77750
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86981b1538f08e728842dcc974ebfb45bd2aea83
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list