Change in ovirt-engine[master]: aaa: Rename error to error_description and error_code to error
Code Review
gerrit at ovirt.org
Sun Jun 25 22:11:37 UTC 2017
>From Martin Peřina <mperina at redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: Rename error to error_description and error_code to error
......................................................................
aaa: Rename error to error_description and error_code to error
Rename error to error_description
and error_code to error for both
OAuth and OpenId code in SSO.
Change Welcome servlet code to
reflect the changes.
Change-Id: I2437e07fb8dc1c2897002b5887c1c2d1f7ee4561
Bug-Url: https://bugzilla.redhat.com/1416491
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OpenIdUserInfoServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LoginServlet.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LogoutServlet.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/OAuthCallbackServlet.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeUtils.java
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp
9 files changed, 42 insertions(+), 34 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2437e07fb8dc1c2897002b5887c1c2d1f7ee4561
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list