Change in ovirt-engine[master]: core: Set destroy_on_reboot flag for VMs with changed config

[Code Review]

>From Martin Betak <mbetak at redhat.com>:

Martin Betak has submitted this change and it was merged.

Change subject: core: Set destroy_on_reboot flag for VMs with changed config
......................................................................


core: Set destroy_on_reboot flag for VMs with changed config

Currently the engine controlled "cold reboot" feature - i.e. shut down and then
start VMs with next run configuration (or run-once) - has been only enacted on
reboots triggered by the engine itself and not from reboots initiated from
within the guest systems itself. In those cases the QEMU process survived and
only a "hot reboot" was performed.

Now using the new `setDestroyOnReboot` VDSM verb (and corresponding
ovirt-vm:destroy_on_reboot VM XML element) we can set a trap on the VDSM side
that in case of a detected guest-reboot will destroy the VM with the
DESTROYED_ON_REBOOT exit reason which can be then translated in the VmAnalyzer
to the existing cold-reboot engine flow.

Change-Id: I0e7ed73a161710aa78808c2b632e238ab75fbca9
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmExitReason.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateBrokerVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetDestroyOnRebootVDSCommand.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
17 files changed, 101 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Martin Betak: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78194
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0e7ed73a161710aa78808c2b632e238ab75fbca9
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>