Change in ovirt-engine[master]: core: change SyncAttachedDirectLunsCommand purpose

Code Review gerrit at ovirt.org
Wed Jun 28 14:19:13 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: change SyncAttachedDirectLunsCommand purpose
......................................................................


core: change SyncAttachedDirectLunsCommand purpose

This patch renames the command to SyncDirectLunsCommand and makes it
possible to:
1. Synchronize all the direct LUNs that are attached to VMs in the data
center using a data center ID.
2. Synchronize any direct LUN using a host ID, rather than a list of
direct luns that are attached to a VM in the data center.

Change-Id: Ied75ea0fbc247654f87c132e75a00be5f15e0b88
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAllUsedLunsCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncDirectLunsCommand.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncDirectLunsCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActionType.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncAttachedDirectLunsParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncDirectLunsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDaoImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskLunMapDaoTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/disk_lun_map_sp.sql
17 files changed, 374 insertions(+), 277 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/78532
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied75ea0fbc247654f87c132e75a00be5f15e0b88
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>


More information about the Engine-commits mailing list