Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: fix wrong failure of space requirement validation

Code Review gerrit at ovirt.org
Wed Mar 1 11:16:46 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: fix wrong failure of space requirement validation
......................................................................


core: fix wrong failure of space requirement validation

When copying a template's disk to a storage domain, the
StorageDomainValidator#hasSpaceForDiskWithSnapshots calculates
the disk's size with all other disk's copies as well which may results
in the wrong failure of the space requirement validation

This is fixed by only the image we are copying to the image
snapshots list, because it's the only one relevant to the
calculation of the free space.

Change-Id: Ibd5a925197e94a12e43a2c97d9350b913d209bf5
Bug-Url: https://bugzilla.redhat.com/1414320
Signed-off-by: Benny Zlotnik <bzlotnik at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd5a925197e94a12e43a2c97d9350b913d209bf5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>


More information about the Engine-commits mailing list