Change in ovirt-engine[master]: core: Monitor devices only for vms that are already in the db

Code Review gerrit at ovirt.org
Wed Mar 1 16:45:12 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: Monitor devices only for vms that are already in the db
......................................................................


core: Monitor devices only for vms that are already in the db

Before this fix vm devices hash was stored in an internal cache
for all vms that were reported by vdsm no matter if they were
present in the engine db at the time.

This caused problems with hosted engine vm that was imported
after the device hash was saved in the cache. Since device monitoring
relies on this cache and there was no change in the hash reported
from vdsm and the hash in the cache the devices weren't imported.

This patch allows monitoring caching info only for vms that already
exist in the db and so solves this issue.

Change-Id: Ib011ac5c7f28de7891b0b6e3c09b107679c1ff29
Bug-Url: https://bugzilla.redhat.com/1425108
Signed-off-by: Jenny Tokar <jtokar at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresher.java
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved
  Jenny Tokar: Verified



-- 
To view, visit https://gerrit.ovirt.org/73237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib011ac5c7f28de7891b0b6e3c09b107679c1ff29
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list