Change in ovirt-engine[master]: webadmin: Add specialized validation for Long values

Code Review gerrit at ovirt.org
Thu Mar 2 08:58:39 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Add specialized validation for Long values
......................................................................


webadmin: Add specialized validation for Long values

This patch adds a LongValidation class to provide validation of Long
values.

Previously, the EditQuotaClusterModel and EditQuotaStorageModel classes
used the IntegerValidation class to validate some Long type values,
which resulted in mistakes such as those detailed in
https://bugzilla.redhat.com/1423468.

Change-Id: Ieddd09396be5bdb113bec430afa71913715130db
Bug-Url: https://bugzilla.redhat.com/1423468
Signed-off-by: Tony Wang <Sline798 at gmail.com>
Signed-off-by: Phillip Bailey <phbailey at redhat.com>
---
A backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/LongCompat.java
A backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/LongCompatTest.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaClusterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaStorageModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/LongValidation.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
8 files changed, 140 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Tony Wang: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/72669
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieddd09396be5bdb113bec430afa71913715130db
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tony Wang <sline798 at gmail.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tony Wang <sline798 at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list