Change in ovirt-engine-sdk[master]: Don't avoid reserved words in enum values text

Code Review gerrit at ovirt.org
Fri Mar 3 11:49:50 UTC 2017


>From Ondra Machacek <omachace at redhat.com>:

Ondra Machacek has submitted this change and it was merged.

Change subject: Don't avoid reserved words in enum values text
......................................................................


Don't avoid reserved words in enum values text

The SDK appends an underscore to generated names that conflict with
Python reserved words. But it also does so for the text of enum
values. This is wrong. This patch fixes it.

Change-Id: Ibf6106a7f34cdf5bf4fb71100f9c247300ea7f02
Signed-off-by: Ondra Machacek <omachace at redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/TypesGenerator.java
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Ondra Machacek: Verified; Looks good to me, approved
  Juan Hernandez: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73518
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf6106a7f34cdf5bf4fb71100f9c247300ea7f02
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list