Change in ovirt-engine[master]: core: minor cleanup in the VM class
Code Review
gerrit at ovirt.org
Sun Mar 5 09:38:56 UTC 2017
>From Arik Hadas <ahadas at redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: minor cleanup in the VM class
......................................................................
core: minor cleanup in the VM class
1. Fields to appear first
2. Methods to appear last
3. Remove redundant comment
4. Remove redundant interface 'Reasoned'
Change-Id: I7a152cb4710d0eb05f3cca3962255e470f56dbc1
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Reasoned.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
3 files changed, 52 insertions(+), 87 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/73140
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a152cb4710d0eb05f3cca3962255e470f56dbc1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list