Change in ovirt-engine[master]: core: VdsBrokerObjectsBuilder#assignLongValue nulls

Code Review gerrit at ovirt.org
Sun Mar 5 10:42:46 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: VdsBrokerObjectsBuilder#assignLongValue nulls
......................................................................


core: VdsBrokerObjectsBuilder#assignLongValue nulls

If a value is null, it obviously can't be parsed to a Long, so there's
no reason to even try.

This patch solves Coverity CID 1361094.

Change-Id: Iee0228ce2dc78e4d14625ca95fdf914f6f29f168
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/73493
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iee0228ce2dc78e4d14625ca95fdf914f6f29f168
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list