Change in ovirt-engine[master]: core: Remove DummyPredicate

Code Review gerrit at ovirt.org
Tue Mar 7 03:00:18 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove DummyPredicate
......................................................................


core: Remove DummyPredicate

DummyPredicate was introduced when the engine used a Mockito version
that could not partially mock an interface and retain its default
implementation.

Now that the engine uses a Mockito version with those capabilities, this
class can safely be replace with spied instances and removed from the
project completely.

Change-Id: Icd5460e6942f85f302984846b8128532905fc95a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/predicate/ManagementNetworkCandidatePredicateTest.java
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DummyPredicate.java
2 files changed, 8 insertions(+), 35 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Martin Betak: Looks good to me, but someone else must approve
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/73616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd5460e6942f85f302984846b8128532905fc95a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list