Change in ovirt-engine[ovirt-engine-3.6]: core: Allow memory over commitment only if ksm or ballooning...

Code Review gerrit at ovirt.org
Tue Mar 14 10:02:52 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Allow memory over commitment only if ksm or ballooning are available
......................................................................


core: Allow memory over commitment only if ksm or ballooning are available

Currently we allow memory over commitment even if nothing can
support it on a host (no ksm and no ballooning).
This patch adds verification for that issue so an error is raised
if the configuration is wrong.

Change-Id: I912285e8d8cd1d55cf58b14bf04f7d2e8bb84e75
Bug-Url: https://bugzilla.redhat.com/1427844
Signed-off-by: Jenny Tokar <jtokar at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
A packaging/dbscripts/upgrade/03_06_2180_disable_cluster_over_commintment_if_no_ksm_or_balooning_enabled.sql
10 files changed, 94 insertions(+), 2 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Jenny Tokar: Verified



-- 
To view, visit https://gerrit.ovirt.org/73982
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I912285e8d8cd1d55cf58b14bf04f7d2e8bb84e75
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>


More information about the Engine-commits mailing list