Change in ovirt-engine[master]: core: Reduce scope of class member in DiskValidatorTest

Code Review gerrit at ovirt.org
Tue Mar 14 17:10:38 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Reduce scope of class member in DiskValidatorTest
......................................................................


core: Reduce scope of class member in DiskValidatorTest

The lunDisk class member is only used in one method and can be defined
as a local variable

Change-Id: I3ca0019c950187be7b7f4ea30d86061c99fd940e
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/74058
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ca0019c950187be7b7f4ea30d86061c99fd940e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list