Change in ovirt-engine[master]: scheduling: Refactor swap check to follow the same logic as ...

[Code Review]

>From Martin Sivák <msivak at redhat.com>:

Martin Sivák has submitted this change and it was merged.

Change subject: scheduling: Refactor swap check to follow the same logic as other policy units
......................................................................


scheduling: Refactor swap check to follow the same logic as other policy units

This allows per-cluster configuration of the allowed swap usage check.

The global option BlockMigrationOnSwapUsagePercentage is still used,
but can be overriden by the standard cluster policy mechanisms.

The global option EnableSwapCheck will disable this unit for all
clusters independently on the cluster policy configuration.

Swap check can be disabled for a single cluster by creating a new cluster
policy with the new Swap policy unit removed from the list of filters.

This change also modifies the algorithm slightly and uses Free memory
instead of the Available memory approximation VDSM provides.

Change-Id: I8af60f54e31142a851fccc3e1a5b9df30dce93b7
Signed-off-by: Martin Sivak <msivak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPolicies.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalPolicyUnits.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitParameter.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/SwapFilterPolicyUnit.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 118 insertions(+), 36 deletions(-)

Approvals:
  Martin Sivák: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Jenny Tokar: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/68007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8af60f54e31142a851fccc3e1a5b9df30dce93b7
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>