Change in ovirt-engine[master]: webadmin, userportal: GWT/P upgrade, part 1

[Code Review]

>From Vojtech Szocs <vszocs at redhat.com>:

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: GWT/P upgrade, part 1
......................................................................


webadmin,userportal: GWT/P upgrade, part 1

- bump dependency versions in POM files
  * GWT 2.6.1 -> 2.8.0
  * GWT-Platform 1.3.1 -> 1.6
  * Guice (DI API) 3.0 -> 4.1.0
  * GIN (DI impl) 2.1.2 (no change, no release activity since Nov 2013)

  Note: GWT-Platform POM effectively determines the versions to be used,
  including GWT, Guice and GIN. Above version changes therefore reflect
  what GWT-Platform (1.6) expects.

- stop using GinUiBinder:
  1, it's basically a hack (override of) GWT UiBinder generator
  2, it's not part of GWT-Platform core classes anymore:
     https://github.com/ArcBees/gwtp-extensions/tree/master/ginuibinder
  3, used by two classes, actually needed only by one (IconEditorWidget)
  4, oVirt UI devs never got to using @Inject-capable widgets in .ui.xml

Change-Id: I8fa315e1f54dca915cde3d3e6edf5055512f0f7a
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/CommonGinUiBinderWidgets.java
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ElementAwareDecoratedPopupPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.java
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/ClientGinjectorExtension.java
D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UserPortalGinUiBinderWidgets.java
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/WebAdminGinUiBinderWidgets.java
M pom.xml
13 files changed, 85 insertions(+), 160 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Alexander Wels: Looks good to me, approved
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8fa315e1f54dca915cde3d3e6edf5055512f0f7a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>