Change in ovirt-engine[master]: webadmin, userportal: GWT/P upgrade, part 3

Code Review gerrit at ovirt.org
Wed Mar 15 16:15:13 UTC 2017


>From Vojtech Szocs <vszocs at redhat.com>:

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: GWT/P upgrade, part 3
......................................................................


webadmin,userportal: GWT/P upgrade, part 3

- remove "animal.sniffer.gwt.skip" property across all POM files
  * GWT 2.8+ supports Java 8 language syntax and expects the source
    level to be Java 8 by default
  * GWT 2.8+ has partial support of new Java 8 standard library APIs:
    http://www.gwtproject.org/release-notes.html#Release_Notes_2_8_0_RC1
  * all Engine Maven modules are now Java 8 (src & target) compliant

- in root POM, remove "animal-sniffer-maven-plugin:check" execution
  * no "animal.sniffer.gwt.skip" property means no need for this plugin

- org.aspectj:{aspectjrt,aspectjweaver} version bumped to 1.8.10

- update GwtCommon.gwt.xml:
  * remove GWT log handlers that are disabled by default or got removed
  * with AOP stuff extracted into gwt-aop module, we no longer need to
    exclude gwt-extension Java classes from GIN class loading

- remove redundant <encoding> config values in frontend modules POM

Change-Id: Iaa91972ce41ef9daedb9e795973ee506aa44bc00
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/extensions-api-root/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml
M frontend/webadmin/modules/pom.xml
M pom.xml
8 files changed, 34 insertions(+), 128 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Alexander Wels: Looks good to me, approved
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa91972ce41ef9daedb9e795973ee506aa44bc00
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list