Change in ovirt-engine[master]: webadmin, userportal: GWT/P upgrade, part 6

[Code Review]

>From Vojtech Szocs <vszocs at redhat.com>:

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: GWT/P upgrade, part 6
......................................................................


webadmin,userportal: GWT/P upgrade, part 6

- remove IconEditorWidget#clickElement (use FileUpload#click)

- AbstractHeader#onBrowserEvent now calls super

- remove GWT-specific TimeSpan#toString (not needed on client)

- update GWT-specific DateTime#toString(Object) for consistency
  with GWT-specific DateUtils (working with GWT DateTimeFormat)

- improve existing TODO-GWT comments for outstanding issues

- add gwt-aop/exclude-filters.xml to make findbugs-maven-plugin
  happy (if missing, it fails the whole FindBugs-enabled build)

Change-Id: Ied202692c89af8fa37b7a0e4aaa75debb3563fb9
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeSpan.java
A frontend/webadmin/modules/gwt-aop/exclude-filters.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/section/main/presenter/OptionsPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/MenuBar.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CheckboxCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CompositeCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/AbstractHeader.java
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/DateTime.java
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/TimeSpan.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/SystemTreeModelProvider.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/bookmark/BookmarkList.java
14 files changed, 50 insertions(+), 54 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Vojtech Szocs: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests
  Greg Sheremeta: I would prefer that you didn't submit this



-- 
To view, visit https://gerrit.ovirt.org/73554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied202692c89af8fa37b7a0e4aaa75debb3563fb9
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>