Change in ovirt-engine[master]: core: Support QCOW compat update for disk update

Code Review gerrit at ovirt.org
Wed Mar 15 17:38:32 UTC 2017


>From Maor Lipchuk <mlipchuk at redhat.com>:

Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Support QCOW compat update for disk update
......................................................................


core: Support QCOW compat update for disk update

Updating QCOW compat version for QCOW disk was only supported through
the API of disks and storage domains.

This patch adds the ability to also update the QCOW compat through the
diskattachments API update by adding logic to UpdateVmDiskCommand.

Change-Id: I5d038b84089d2775e79c656f6f4647bcbf5d61f2
Bug-Url: https://bugzilla.redhat.com/1429437
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 146 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Verified
  Liron Aravot: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/73642
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5d038b84089d2775e79c656f6f4647bcbf5d61f2
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list