Change in ovirt-engine[master]: core: removed unnecessary flag, extracted method

Code Review gerrit at ovirt.org
Thu Mar 16 09:29:23 UTC 2017


>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged.

Change subject: core: removed unnecessary flag, extracted method
......................................................................


core: removed unnecessary flag, extracted method

• flag plugOfAllMacsSucceeded was unneeded, it's value can be
calculated when needed. (also was wrong in principle, as it was set to
true before any plug happened)

• extracted method doing all replugs for better readability

Change-Id: I196be8190aa5e92d0a8e819d5462b6c3e9e483fe
Bug-Url: https://bugzilla.redhat.com/1408801
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 21 insertions(+), 18 deletions(-)

Approvals:
  Martin Mucha: Verified
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/70733
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I196be8190aa5e92d0a8e819d5462b6c3e9e483fe
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list