Change in ovirt-engine[master]: ui: Seal Template checkbox in Make Template dialog
Code Review
gerrit at ovirt.org
Thu Mar 16 23:16:14 UTC 2017
>From Arik Hadas <ahadas at redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: ui: Seal Template checkbox in Make Template dialog
......................................................................
ui: Seal Template checkbox in Make Template dialog
Added 'Seal Template' checkbox in Make Template dialog. When the
checkbox checked, the template will be sealed immediately after
creation. Sealing is performed with virt-sysprep tool.
virt-sysprep erases all host-specific configuration from the filesystem:
SSH keys, UDEV rules, MAC addresses, system ID, hostname etc., thus
making it easy to use a VM as template without manual intervention.
Change-Id: Iee7b7eef27fce63116b85a2bafc01428287c94aa
Bug-Url: https://bugzilla.redhat.com/1335642
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/template/UnitToAddVmTemplateParametersBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
7 files changed, 27 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
--
To view, visit https://gerrit.ovirt.org/68117
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee7b7eef27fce63116b85a2bafc01428287c94aa
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list