Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: Properly adjust # of usb-controllers in UpdateTemplate...

Code Review gerrit at ovirt.org
Mon Mar 20 10:11:46 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Properly adjust # of usb-controllers in UpdateTemplate & AddVm
......................................................................


core: Properly adjust # of usb-controllers in UpdateTemplate & AddVm

The VmDeviceUtils#updateUsbSlots method was not being called in the flows in
UpdateVmTemplateCommand and AddVmCommand, which resulted in creation of
templates (and consequently also VMs) with incorrect number of usb controllers
and thus preventing the VM to be run in some cases.

Change-Id: Ic8fbae5d863307bc423c3e04cfd56c370a850863
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430009
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
3 files changed, 21 insertions(+), 20 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Martin Betak: Looks good to me, but someone else must approve
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Michal Skrivanek: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/74251
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8fbae5d863307bc423c3e04cfd56c370a850863
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list