Change in ovirt-engine[master]: packaging: Update only invalid values in postgres.conf

Code Review gerrit at ovirt.org
Mon Mar 20 16:13:31 UTC 2017


>From Sandro Bonazzola <sbonazzo at redhat.com>:

Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: Update only invalid values in postgres.conf
......................................................................


packaging: Update only invalid values in postgres.conf

Motivation:
The updater of the conf was changing even valid config item. We want to
leave those in place in case someone already took care of that and tweak
the system correctly and not override valid values.

Change:
Make sure valid values are not counted for edition.

Result:
Valid pg values are not amended. If postgres had autovacuum_max_workers
set to 8 and valid value is >= 6 then it is left untouched.

Change-Id: Id06bce50b72544e2f9ee72942a3f6344393f87ce
Bug-Url: https://bugzilla.redhat.com/1388433
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine_common/database.py
1 file changed, 2 insertions(+), 9 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Martin Peřina: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Yedidyah Bar David: Looks good to me, but someone else must approve
  Roy Golan: Verified



-- 
To view, visit https://gerrit.ovirt.org/73818
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id06bce50b72544e2f9ee72942a3f6344393f87ce
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list