Change in ovirt-engine[master]: core: Tests import order

Code Review gerrit at ovirt.org
Wed Mar 22 11:54:50 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Tests import order
......................................................................


core: Tests import order

Fix the tests' import order - static imports should come first.

While this is not currently a problem with the current checkstyle
(other than the annoyance maintaining this class), it will break
under newer checkstyle versions).

Change-Id: Ie95283c31835d21c928e4dc4599a4c44f7fa97f4
Related-To: https://bugzilla.redhat.com/1433408
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateRngDeviceTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmSlaPolicyCommandTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/CpuQosDaoTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/network/predicate/AbstractVdsNetworkInterfacePredicateTest.java
7 files changed, 24 insertions(+), 24 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Sivák: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Martin Betak: Looks good to me, but someone else must approve
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/74424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie95283c31835d21c928e4dc4599a4c44f7fa97f4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list