Change in ovirt-engine[master]: webadmin: EventProvidingCollection left curly

Code Review gerrit at ovirt.org
Wed Mar 22 11:54:50 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: EventProvidingCollection left curly
......................................................................


webadmin: EventProvidingCollection left curly

Move the left curly to the class' definition line, as per the
project's coding standard.

While placing the curly bracket on a new line isn't strictly wrong in
the current codebase (just inelegant), it will actually break in
newer checkstyle versions.

Change-Id: I616413508bfafabc59a5d8dc9337ba4f60c7cbf7
Related-To: https://bugzilla.redhat.com/1433408
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/74426
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I616413508bfafabc59a5d8dc9337ba4f60c7cbf7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list