Change in ovirt-engine[master]: build: NlsCheck#patternString modifiers

[Code Review]

>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: build: NlsCheck#patternString modifiers
......................................................................


build: NlsCheck#patternString modifiers

Declare the constant as private static final, as per Java's best
practices.

If Maven's Checkstyle plugin creates multiple instances of the checks
it uses this change should also offer some performance improvement,
as the various instances would share the same compiled pattern
instead of having to compile it anew each time an instance is
created.

Change-Id: Id42b2db8ca8ccc6000ff24705c6d7b806fa1117f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NlsCheck.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Peřina: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests
  Vojtech Szocs: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/74432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id42b2db8ca8ccc6000ff24705c6d7b806fa1117f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>