Change in ovirt-engine[master]: build: Extend AbstractCheck instead of Check

Code Review gerrit at ovirt.org
Wed Mar 22 21:26:31 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: build: Extend AbstractCheck instead of Check
......................................................................


build: Extend AbstractCheck instead of Check

Checkstyle 6.16 deprecated the Check class by hollowing it out and
converting it to an empty extension of AbstractCheck.

This patch consumes this change by making oVirt's checks extend
AbstractCheck directly instead of extending the now deprecated Check.

Change-Id: I4a6a986aeab11b04e495b00d747eb17a425b905b
Related-To: https://bugzilla.redhat.com/1433408
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/DiamondOperatorCheck.java
M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NlsCheck.java
M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NoArgConstructorCheck.java
M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NoFinalMemberCheck.java
M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NoMemberInitializationCheck.java
5 files changed, 10 insertions(+), 10 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Peřina: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests
  Vojtech Szocs: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/74430
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a6a986aeab11b04e495b00d747eb17a425b905b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list