Change in ovirt-engine[master]: build: Upgrade checkstyle version

[Code Review]

>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: build: Upgrade checkstyle version
......................................................................


build: Upgrade checkstyle version

This patch upgrades Checkstyle and Maven Checkstyle Plugin the
project uses to the latests versions (7.6 and 2.17, respectively).

Since the project hasn't upgraded its Checkstyle version for quite
some time (the previously used version was 6.8), this upgrade
introduces some changes that are not backwards compatible and had to
be fixed:
- A suppression was added for all the checks on the generated
  sources, as we can't control their style anyway
- A suppression was added for properties files which weren't analyzed
  with the previous checkstyle version
- ScopeUtils was moved from com.puppycrawl.tools.checkstyle to
  com.puppycrawl.tools.checkstyle.utils
- Its method inInterfaceOrAnnotationBlock was renamed to
  isInInterfaceOrAnnotationBlock

Note that the Checkstyle 7 generation deprecated some classes and
added some new abilities.
Consuming these changes is NOT in the scope of this patch, and will
be handled by the following patches in the series.

Change-Id: I7eae4cbd726e67f3f1b3542208110d831f38a9b7
Bug-Url: https://bugzilla.redhat.com/1433408
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/extensions-api-root/pom.xml
M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml
M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NoMemberInitializationCheck.java
M pom.xml
4 files changed, 14 insertions(+), 5 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Sandro Bonazzola: Looks good to me, but someone else must approve
  Martin Peřina: Looks good to me, but someone else must approve
  Eyal Edri: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/74429
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7eae4cbd726e67f3f1b3542208110d831f38a9b7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>