Change in ovirt-engine[master]: doc: Update the README
Code Review
gerrit at ovirt.org
Thu Mar 23 13:42:00 UTC 2017
>From Vojtech Szocs <vszocs at redhat.com>:
Vojtech Szocs has submitted this change and it was merged.
Change subject: doc: Update the README
......................................................................
doc: Update the README
- on a local development environment, running the GWT
application through Super Dev Mode, e.g.
$ make gwt-debug DEBUG_MODULE=webadmin \
DEV_BUILD_GWT_SUPER_DEV_MODE=1
is always better than one-time GWT "draft" compile,
because of two reasons:
1, SDM automatically disables all optimizations
2, SDM allows you to recompile the GWT application
on the fly (incremental recompiles are fast)
- removed "build Engine with DEV_BUILD_GWT_SUPER_DEV_MODE=1"
because that's not really necessary, see [1] for details
[1] http://www.gwtproject.org/articles/superdevmode.html
see section titled "How the bookmarklet works"
Change-Id: I0f0eae5f861d07ba44591fd482f3f0fbb64b00e0
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M README.adoc
1 file changed, 13 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Verified
Scott Dickerson: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74265
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f0eae5f861d07ba44591fd482f3f0fbb64b00e0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list