Change in ovirt-engine[ovirt-engine-4.1]: core: getQemuImageInfo should not call teardown on live snap...
Code Review
gerrit at ovirt.org
Fri Mar 24 11:06:27 UTC 2017
>From Piotr Kliczewski <piotr.kliczewski at gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: getQemuImageInfo should not call teardown on live snapshot.
......................................................................
core: getQemuImageInfo should not call teardown on live snapshot.
Once a live snapshot is performed the volume should already be active
in the host and therefore should not be prepared and teardown when
executing getQemuImageInfo.
The fix for this is to check whether the VM, the disks is attached to,
is running, get the host that is running on and call getQemuImageInfo
with that host without the prepare and teardown.
Change-Id: Iadc5d353744cffab8575e5dc4945b707cdca7d59
Bug-Url: https://bugzilla.redhat.com/1433052
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java
3 files changed, 41 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/74571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadc5d353744cffab8575e5dc4945b707cdca7d59
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list