Change in ovirt-engine[ovirt-engine-4.1]: core: Fix update of video devices in UpdateVmTemplateCommand

Code Review gerrit at ovirt.org
Mon Mar 27 11:22:27 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Fix update of video devices in UpdateVmTemplateCommand
......................................................................


core: Fix update of video devices in UpdateVmTemplateCommand

The proper VmDeviceUtils#updateVideoDevices was only called from
UpdateVmCommand and UpdateVmTemplateCommand contained only a snippet of code
that covered just a small fraction of all the possible flows. Replaced this
handling in UpdateVmTemplateCommand with proper call to
VmDeviceUtils#updateVideoDevices.

Change-Id: Id4c139248fdfa0774f883d9737bcbc2c627d2cff
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1434161
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
2 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Martin Betak: Verified



-- 
To view, visit https://gerrit.ovirt.org/74580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4c139248fdfa0774f883d9737bcbc2c627d2cff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list