Change in ovirt-engine[ovirt-engine-4.1]: core: Introducing SealVmTemplateCommand

Code Review gerrit at ovirt.org
Wed Mar 29 15:07:12 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Introducing SealVmTemplateCommand
......................................................................


core: Introducing SealVmTemplateCommand

Added SealVmTemplateCommand to execute virt-sysprep on disks connected
to a VM.  The command is intended to be run from AddVmTemplateCommand.

Added SealDisksVDSCommand that executes virt-sysprep over collection of
disk images.

virt-sysprep erases all host-specific configuration from the filesystem:
SSH keys, UDEV rules, MAC addresses, system ID, hostname etc., thus
making easy to use a VM as template without manual intervention.

Change-Id: I36361d552b02affa63c2f07e64e6e0bcb44187eb
Bug-Url: https://bugzilla.redhat.com/1436219
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SealVmTemplateCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SealVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SealDisksVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SealDisksVDSCommand.java
10 files changed, 247 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/74674
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I36361d552b02affa63c2f07e64e6e0bcb44187eb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list