Change in ovirt-engine[master]: core: extract lun's discard logic to the LUNs class

Code Review gerrit at ovirt.org
Thu Mar 30 11:25:29 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: extract lun's discard logic to the LUNs class
......................................................................


core: extract lun's discard logic to the LUNs class

This patch extracts duplicated code about discard support to two new
methods in Luns: supportsDiscard and hasDiscardZeroesTheDataSupport.

Change-Id: I521ce2f96f074418fce604a4e25ea388860215e1
Related-To: https://bugzilla.redhat.com/1436160
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/BlockStorageDiscardFunctionalityHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskVmElementValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LUNs.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
4 files changed, 19 insertions(+), 26 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved; Passed CI tests
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/74749
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I521ce2f96f074418fce604a4e25ea388860215e1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list