Change in ovirt-engine[master]: webadmin: make SanStorageModelBase.getAddedLuns reusable
Code Review
gerrit at ovirt.org
Thu Mar 30 11:25:30 UTC 2017
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: make SanStorageModelBase.getAddedLuns reusable
......................................................................
webadmin: make SanStorageModelBase.getAddedLuns reusable
getAddedLuns used to return only the newly added luns, without the
included ones (those which were already selected before).
This patch adds a new method, getLuns, that receives parameters that
indicate which luns to return - the added and the included ones.
Change-Id: I67717bd3d9ec8c3332e94c0004f567e52294a264
Related-To: https://bugzilla.redhat.com/1436160
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
1 file changed, 13 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/74578
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67717bd3d9ec8c3332e94c0004f567e52294a264
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list