Change in ovirt-engine[ovirt-engine-4.1]: core : Storage domains not showing in search on a DC named w...

Code Review gerrit at ovirt.org
Fri Mar 31 16:41:33 UTC 2017


>From Piotr Kliczewski <piotr.kliczewski at gmail.com>:

Piotr Kliczewski has submitted this change and it was merged.

Change subject: core : Storage domains not showing in search on a DC named with an underscore
......................................................................


core : Storage domains not showing in search on a DC named with an underscore

When data center name has an underscore in them
the search sql for storage domains for the data
center is executed with escaped data center name.

This causes issue when the escaped name is used
in the left hand side of the like clause. When
the name is used on the left hand side of the
like clause it does not have to be escaped.

Change-Id: I3049eb2641d7a86b0b857aa9a46376d794d14812
Bug-Url: https://bugzilla.redhat.com/1409849
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java
3 files changed, 27 insertions(+), 19 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Ravi Nori: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/74977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3049eb2641d7a86b0b857aa9a46376d794d14812
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list