Change in ovirt-engine[master]: engine: Avoid log injection in HostNetworkTopologyPersisterImpl

Code Review gerrit at ovirt.org
Mon May 1 21:06:36 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: engine: Avoid log injection in HostNetworkTopologyPersisterImpl
......................................................................


engine: Avoid log injection in HostNetworkTopologyPersisterImpl

Since all of the data to be logged is already present at the creating of
the audit-log entity, there is no need to inject any beans to the
AuditLogableBase and it can be replaced with a leaner and more efficient
implementation of the AuditLogable.

Change-Id: If19f402976dbe76a9534fd547dba4a63467b826b
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java
1 file changed, 11 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Moti Asayag: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/76129
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If19f402976dbe76a9534fd547dba4a63467b826b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list