Change in ovirt-engine[master]: webadmin: HostNetworkProviderModel NPE

Code Review gerrit at ovirt.org
Wed May 3 13:48:54 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: HostNetworkProviderModel NPE
......................................................................


webadmin: HostNetworkProviderModel NPE

This patch checks that provider is not null before passing it
getNeutronAgentModel().init(Provider), which dereferences it, in
order to avoid an NPE there.

This patch fixes Coverity CID 1374422.

Change-Id: Id758cf209e83d6f68a63504af1995d22f7c3a136
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/HostNetworkProviderModel.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/76069
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id758cf209e83d6f68a63504af1995d22f7c3a136
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list