Change in ovirt-engine[master]: core: Avoid injection in GetVmsFromExportDomainQuery

Code Review gerrit at ovirt.org
Thu May 4 13:28:59 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Avoid injection in GetVmsFromExportDomainQuery
......................................................................


core: Avoid injection in GetVmsFromExportDomainQuery

Since all of the data to be logged is already present at the creating of
the audit-log entity, there is no need to inject any beans to the
AuditLogableBase and it can be replaced with a leaner and more efficient
implementation of the AuditLogable.

Change-Id: I57520bf1b0c4a775c7e6b14f1d5b1b979e800fcb
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/GetVmsFromExportDomainQuery.java
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/76370
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I57520bf1b0c4a775c7e6b14f1d5b1b979e800fcb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list